Bug fixed for Cannot create SharedArrayBuffer#3218
Closed
Noorain464 wants to merge 2 commits intoprocessing:developfrom
Closed
Bug fixed for Cannot create SharedArrayBuffer#3218Noorain464 wants to merge 2 commits intoprocessing:developfrom
Noorain464 wants to merge 2 commits intoprocessing:developfrom
Conversation
Noorain464
changed the title
Collaborator
|
Thanks for your work on this! It seems that the solution here is similar to the one provided in an earlier PR, which I closed since it didn't seem to entirely work, and I'm not able to do it here either. Based on the example code provided in the issue, it seems like this is what is supposed to happen when it's working, which also doesn't seem to appear in the screenshots you've provided. Since we've closed a PR with a similar solution to this, I'm going to close this one as well. I'm sorry that we couldn't get this in, but please feel free to reopen this with any updates! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #issue-number:Cannot create a SharedArrayBuffer #2094
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123